[amp-story-player] 馃悰 Fixes firefox bug #27756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
force-pushed
the
firefox-bug
branch
2 times, most recently
from
0efcf2d
to
19da6b7
Compare
gmajoulet
reviewed
Apr 14, 2020
gmajoulet
approved these changes
Apr 14, 2020
|
/to @danielrozenberg for OWNERS approval EDIT: just noticed the bot already requested @estherkim , sorry for the double ping to infra :p |
danielrozenberg
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27538
When calling
applySandbox(),devAssert()was being called since one of the flags in the sandbox of the iframe isn't allowed in firefox. And sincedevAssert()hasn't been initialized, it was throwing an error. CallinginitLogConstructor()initializes it.