Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send hit using GET method instead in POST method for mediametrie analytics. #2780

Merged
merged 1 commit into from Apr 1, 2016

Conversation

loic-seguin
Copy link

We just changed the way to send the request in GET instead in POST.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@loic-seguin
Copy link
Author

I already signed it !

@rudygalfi
Copy link
Contributor

Quick review. LGTM

@avimehta
Copy link
Contributor

avimehta commented Apr 1, 2016

@loic-seguin Maybe the email associated with your github account is different from the email you signed the CLA with? Can you confirm?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@loic-seguin
Copy link
Author

Everything is ok with the CLA, I changed the email of the commiter.

@avimehta
Copy link
Contributor

avimehta commented Apr 1, 2016

thanks. Will merge as soon as travis completes tests.

@avimehta avimehta merged commit 6f2b25b into ampproject:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants