Add --define_experiment_constant as valid flag #27814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
suggested changes
Apr 16, 2020
build-system/tasks/build.js
Outdated
| @@ -112,6 +112,7 @@ build.flags = { | |||
| version_override: ' Overrides the version written to AMP_CONFIG', | |||
| custom_version_mark: ' Set final digit (0-9) on auto-generated version', | |||
| watch: ' Watches for changes in files, re-builds when detected', | |||
| defineExperimentConstant: ' Build with experiment const set to true', | |||
There was a problem hiding this comment.
All our flags use snake_case. Can you rename the flag (here and in all call sites) to define_experiment_constant?
Also a nit: For more clarity, change the message to:
Builds runtime with the EXPERIMENT constant set to true
rsimha
approved these changes
Apr 16, 2020
zhouyx
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dvoytenko