馃彈 Update @ampproject/filesize to 4.0.1 with new API
#27898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I restarted the bundle size check and it worked successfully. |
erwinmombay
reviewed
Apr 21, 2020
| @@ -196,6 +196,7 @@ | |||
| "dist/v0/*-?.?.js", | |||
| "dist/*.mjs", | |||
| "dist/v0/*-?.?.mjs" | |||
| ] | |||
| ], | |||
| "trackFormat": ["brotli"] | |||
There was a problem hiding this comment.
this filters out the reporting to just brotli correct?
There was a problem hiding this comment.
This option specifies which formats (compression formats) to track. In the case of AMP, the bundlesize check only cares about brotli.
There was a problem hiding this comment.
I just noticed that yarn add and prettier do not agree on how this setting should be formatted inside package.json. I've filed ampproject/filesize#83 to request that the suggestion in #26907 (comment) (a separate config file for filesize) be implemented.
erwinmombay
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesize 4.0.1 was released with improved concurrency, the ability to filter types of compression, and an updated API.
These changes have been applied in this PR.