Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Do not override inabox host handler" #27919

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Revert "Do not override inabox host handler" #27919

merged 1 commit into from
Apr 22, 2020

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Apr 21, 2020

Reverts #27912

@zhouyx
Copy link
Contributor Author

zhouyx commented Apr 22, 2020

#27912 would break MessageType.FULL_OVERLAY_FRAME and MessageType.CANCEL_FULL_OVERLAY_FRAME. See #27899 (comment) for the reason to revert.

@zhouyx zhouyx merged commit 3b87d5e into master Apr 22, 2020
@rsimha rsimha deleted the revert-27912-inabox-host-handler branch May 15, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@powerivq powerivq Awaiting requested review from powerivq

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @dvoytenko @googlebot @ampprojectbot