Add shared Promise.resolve() babel transform #27960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay, these files were changed: Hey @gmajoulet, these files were changed: Hey @newmuis, these files were changed: Hey @Enriqe, these files were changed: |
cramforce
approved these changes
Apr 22, 2020
samouri
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
I know Babel processing is mainly about transforming files, but does it also have the ability to create new ones? For this transform in particular, it would be neat if it could generate the src/resolved-promise.js file.
All my review comments were nits/questions for my own learning.
LGTM 🚢
| module.exports = function (babel, options = {}) { | ||
| const {types: t} = babel; | ||
| const promiseResolveMatcher = t.buildMatchMemberExpression('Promise.resolve'); | ||
| const {importFrom = 'src/resolved-promise'} = options; |
There was a problem hiding this comment.
Another way to solve the "transform recursion" issue would be if the transform early-exited when transforming the importFrom module.
| @@ -0,0 +1,52 @@ | |||
| /** | |||
| * Copyright 2018 The AMP HTML Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
nit: 2020.
Q: does having the correct current year matter? i.e. is this worth the time spent commenting/fixing?
There was a problem hiding this comment.
Not really. I end up copy pasting this all the time, and forgetting to update.
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
* Add shared Promise.resolve() babel transform * Fixes * Add dependency allowList exceptions * Fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #27901