Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make media pool assert HTTPs-ness of URLs to align with amp-video" #28000

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Revert "Make media pool assert HTTPs-ness of URLs to align with amp-video" #28000

merged 1 commit into from
Apr 23, 2020

Conversation

gmajoulet
Copy link
Contributor

Reverts #27875

@amp-owners-bot
Copy link

Hey @newmuis, these files were changed:

extensions/amp-story/1.0/sources.js
extensions/amp-story/1.0/test/test-media-pool.js
extensions/amp-story/1.0/test/test-media-tasks.js

@estherkim estherkim merged commit f6569bd into master Apr 23, 2020
estherkim pushed a commit that referenced this pull request Apr 24, 2020
@gmajoulet @estherkim
Revert "Make media pool assert HTTPs-ness of URLs to align with amp-v…
93be273 
…ideo (#27875)" (#28000)

This reverts commit dd9b5b2.

(cherry picked from commit f6569bd)
@gmajoulet gmajoulet mentioned this pull request Apr 24, 2020
Closed
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this pull request May 8, 2020
@gmajoulet @ldoroshe
Revert "Make media pool assert HTTPs-ness of URLs to align with amp-v…
dd762b9 
…ideo (ampproject#27875)" (ampproject#28000)

This reverts commit dd9b5b2.
@rsimha rsimha deleted the revert-27875-http-race branch May 15, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newmuis newmuis newmuis approved these changes

@estherkim estherkim estherkim approved these changes

@cramforce cramforce Awaiting requested review from cramforce

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gmajoulet @newmuis @estherkim @googlebot @ampprojectbot