Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Update dependency com.puppycrawl.tools:checkstyle to v8.32 #28040

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Update Change
com.puppycrawl.tools:checkstyle (source) minor 8.31 -> 8.32

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Apr 26, 2020

Hey @ampproject/wg-caching, these files were changed:

validator/java/pom.xml

@rsimha
Copy link
Contributor

rsimha commented Apr 27, 2020

/cc @GeorgeLuo

@honeybadgerdontcare honeybadgerdontcare requested review from Gregable and removed request for honeybadgerdontcare April 27, 2020 12:59
@GeorgeLuo
Copy link
Contributor

Approved, but would you rather I roll up the dependencies for another larger PR? @rsimha

@GeorgeLuo
Copy link
Contributor

Also, at the risk of compounding the things needed to be monitored, these updates to the mvn dependencies don't actually address the bazel build steps.

does that mean the renovate bot isn't looking in the BUILD file? Or that they're passing? Note are plenty of mvn dependencies that aren't included the bazel steps, so it could be just that.

@rsimha
Copy link
Contributor

rsimha commented Apr 27, 2020

Approved, but would you rather I roll up the dependencies for another larger PR? @rsimha

Right now, this PR is blocked because the tests fail. Since this isn't urgent, I'd like to avoid using admin powers to merge this. So feel free to roll this in to your test fix.

Also, at the risk of compounding the things needed to be monitored, these updates to the mvn dependencies don't actually address the bazel build steps.

does that mean the renovate bot isn't looking in the BUILD file? Or that they're passing? Note are plenty of mvn dependencies that aren't included the bazel steps, so it could be just that.

Looking at that file, none of the dependencies appear to be strictly versioned, so I'd imagine the latest versions are being downloaded on Travis each time the tests run. (If there's a way to avoid this, we should. Otherwise, a new release with a breaking change will affect all our Travis builds. I'll leave this part to you, but I'm happy to help.)

@rsimha
Copy link
Contributor

rsimha commented Apr 29, 2020

Force merging in the interest of keeping deps up to date.

@rsimha rsimha merged commit a3f1747 into ampproject:master Apr 29, 2020
@renovate-bot renovate-bot deleted the renovate/com.puppycrawl.tools-checkstyle-8.x branch April 29, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants