Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added required header for analytics.config.json #2810

Merged
merged 1 commit into from Apr 18, 2016
Merged

Added required header for analytics.config.json #2810

merged 1 commit into from Apr 18, 2016

Conversation

avimehta
Copy link
Contributor

@avimehta avimehta commented Apr 5, 2016

Analytics code fails to load the config if the header is not present.

@dvoytenko
Copy link
Contributor

/to @erwinmombay for review

@erwinmombay
Copy link
Member

sorry for late review. LGTM

@erwinmombay erwinmombay merged commit 930c179 into ampproject:master Apr 18, 2016
@avimehta avimehta deleted the analytics branch April 18, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erwinmombay erwinmombay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avimehta @dvoytenko @erwinmombay