Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[amp-social-share][bento][preact] New version of preact social-share component #28137

Merged
merged 25 commits into from
May 14, 2020
Merged

✨[amp-social-share][bento][preact] New version of preact social-share component #28137

merged 25 commits into from
May 14, 2020

Commits on Apr 30, 2020

  1. First draft, new version of preact social-share component

    @krdwan
    krdwan committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    09c3686 View commit details
    Browse the repository at this point in the history

  2. Moved contents to social-share and added story

    @krdwan
    krdwan committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    2baa59a View commit details
    Browse the repository at this point in the history

  3. delete old version of social-share2

    @krdwan
    krdwan committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    4474689 View commit details
    Browse the repository at this point in the history

  4. Adding missed change to story

    @krdwan
    krdwan committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    a87faf1 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2020

  1. Revisions from initial code review

    @krdwan
    krdwan committed May 1, 2020
    Configuration menu
    Copy the full SHA
    3bec731 View commit details
    Browse the repository at this point in the history

  2. renamed private funcitons in amp-social-share

    @krdwan
    krdwan committed May 1, 2020
    Configuration menu
    Copy the full SHA
    8c308e1 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Updated storybook and social-share, renamed from 0.2 to 1.0

    @krdwan
    krdwan committed May 11, 2020
    Configuration menu
    Copy the full SHA
    32e0158 View commit details
    Browse the repository at this point in the history

  2. Adding missed change on amp social share

    @krdwan
    krdwan committed May 11, 2020
    Configuration menu
    Copy the full SHA
    000dfb1 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. More changes to preact component

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    c5ed252 View commit details
    Browse the repository at this point in the history

  2. Add some minor changes in how props are unpacked

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    9caade3 View commit details
    Browse the repository at this point in the history

  3. Removed a typo

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    5eb95c8 View commit details
    Browse the repository at this point in the history

  4. update getQueryString helper

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e58dfb0 View commit details
    Browse the repository at this point in the history

  5. Fix a typo

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4e57360 View commit details
    Browse the repository at this point in the history

  6. Merge with master

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4a2054d View commit details
    Browse the repository at this point in the history

  7. Update to getQueryString helper for use case where a ? exists within … 

    …# params
    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    96b90b2 View commit details
    Browse the repository at this point in the history

  8. Cleaner syntax in getQueryString helper

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e6609df View commit details
    Browse the repository at this point in the history

  9. Even cleaner more elegant syntax for getQueryString

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    e3d162b View commit details
    Browse the repository at this point in the history

  10. Update getQueryString, update versioning from 0.2 to 1.0

    @krdwan
    krdwan committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b778405 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Fixed linter issue, update struct definition

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    fb01ee0 View commit details
    Browse the repository at this point in the history

  2. console /*OK*/.warn to pass linter error (warn in preact env)

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    90de0eb View commit details
    Browse the repository at this point in the history

  3. update config for 0.2 -> 1.0

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    bd2a7b5 View commit details
    Browse the repository at this point in the history

  4. linter updates

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    03e4c56 View commit details
    Browse the repository at this point in the history

  5. Adding parenthesis around type casts

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    19dd93a View commit details
    Browse the repository at this point in the history

  6. Updates for type checking

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    5ad27c2 View commit details
    Browse the repository at this point in the history

  7. removed null coalescing operator to pass pre-merge checks

    @krdwan
    krdwan committed May 14, 2020
    Configuration menu
    Copy the full SHA
    ac3c294 View commit details
    Browse the repository at this point in the history