Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to opt out of GLADE experiment #2817

Merged
merged 1 commit into from Apr 6, 2016

Conversation

mlb7687
Copy link
Contributor

@mlb7687 mlb7687 commented Apr 5, 2016

Add ability to opt out of GLADE experiment with json useSameDomainRenderingUntilDeprecated.

@@ -67,6 +67,19 @@ Supported via `json` attribute:
- `cookieOptions`
- `tagForChildDirectedTreatment`
- `targeting`
- `useSameDomainRenderingUntilDeprecated`

### Temporary Use Of useSameDomainRenderingUntilDeprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please lower case User and Of

@cramforce
Copy link
Member

LGTM. One small nit

@mlb7687
Copy link
Contributor Author

mlb7687 commented Apr 5, 2016

Done.

@cramforce
Copy link
Member

Test error was flake. Merging

@cramforce cramforce merged commit 6525fab into ampproject:master Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants