馃寪 Allow language override from viewer context #28182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmuis
approved these changes
May 4, 2020
gmajoulet
approved these changes
May 4, 2020
dreamofabear
approved these changes
May 4, 2020
|
I've hit a bit of a hiccup here. There's a circular dependency between So my plan is to delete the dependency in |
Enriqe
force-pushed
the
viewer-loc-override
branch
from
434572a
to
c01059a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27023
Original description:
In platform contexts, it makes sense for document-rendered system-level user interfaces to be consistent across documents. This PR allows an AMP viewer or story player to specify a fragment parameter to indicate the language to be used, falling back to the document's language if unspecified.
Follows up on #27990 #27053