Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Reduce coverage threshold for codecov check #28215

Merged
merged 3 commits into from May 6, 2020
Merged

馃彈 Reduce coverage threshold for codecov check #28215

merged 3 commits into from May 6, 2020

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 5, 2020

Background:

PR highlights:

This PR makes a few changes to temporarily work around the issues described above and to enable better debugging:

  • Reduce project-level threshold from 80% to 75%
  • Apply coverage status immediately after the coverage report is uploaded (don't wait for entire Travis build to complete)
  • Don't require entire CI build to pass

Future work:

Continue debugging and figure out if there's a workaround for codecov issue codecov/codecov-bash#83 (comment), and consider using a different service if this continues to be a dealbreaker.

Related to #28212

@rsimha rsimha self-assigned this May 5, 2020
@rsimha rsimha changed the title 馃彈 Choose correct baseline commit for codecov reports 馃彈 Reduce coverage threshold for codecov check May 5, 2020
@rsimha rsimha requested a review from rcebulko May 5, 2020 22:18
@rsimha rsimha marked this pull request as ready for review May 5, 2020 22:18
@amp-owners-bot
Copy link

amp-owners-bot bot commented May 5, 2020

Hey @estherkim! These files were changed:

build-system/pr-check/local-tests.js

@rsimha rsimha requested a review from dreamofabear May 6, 2020 00:08
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; hopefully we can figure out diff coverage soon, that would make a big difference (no pun intended)

@rsimha rsimha merged commit cec4cce into ampproject:master May 6, 2020
@rsimha rsimha deleted the 2020-05-05-CodecovBaseline branch May 6, 2020 21:17
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this pull request May 8, 2020
* Reduce threshold coverage for codecov checks

* Revert change to upload logic

* Don't require entire CI build to pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants