Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毊 Remove skipped old tests #28242

Merged
merged 1 commit into from May 6, 2020
Merged

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented May 6, 2020

No description provided.

Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway to save the git history of test-vendors-new.js?

@zhouyx
Copy link
Contributor Author

zhouyx commented May 6, 2020

I could try break the PR into two. 1. remove test-vendors.js 2. rename test-vendors-new.js. Not sure if that'll help.

@zhouyx zhouyx merged commit 70dc3b7 into ampproject:master May 6, 2020
@zhouyx zhouyx deleted the test-clean-up branch May 6, 2020 22:43
ldoroshe pushed a commit to ldoroshe/amphtml that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants