amp-social-share should not layout without a share endpoint #28285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wassgha
approved these changes
May 8, 2020
| @@ -125,6 +125,10 @@ class AmpSocialShare extends AMP.BaseElement { | |||
|
|
|||
| /** @override */ | |||
| layoutCallback() { | |||
| if (!this.shareEndpoint_) { | |||
| return Promise.resolve(); | |||
There was a problem hiding this comment.
Added a comment to this effect -- the endpoint throws an error if it gets far enough to check it in buildCallback. This case handles when buildCallback returns early after the component hides itself, in which case the internal variable is null for not getting to be resolved. A warning is thrown in one of the hiding cases, and I don't think we need to add an error where this case didn't have one before.
Enriqe
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28260