New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Catch up java validator to Doc Css logic #28313
🐛 Catch up java validator to Doc Css logic #28313
Conversation
GeorgeLuo
commented
May 11, 2020
- Length check of css moved to Doc Css, clean Css length spec references
…lass ValidateTagResult within validateAttributes
…confirm these changes make sense logically
Hey @ampproject/wg-caching! These files were changed:
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Replacing json.org with FasterXML jackson lib.
…uo/amphtml into GeorgeLuo-changes-apr-21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a thorough review for correctness, but Approved to merge.
Let me know if you would like me to make the merge, I don't know if you have merge rights or not. |
don't have merge rights, please merge |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
I think Nhan's consent isn't getting picked up from the bot because he quoted it, ie: It starts with a |
It looks like we're hitting the keyserver issue reported in another thread now. |
that lessens priority to do as rsimha indicates, correct? rather than raises it? |
I'll let Greg comment on the priority of this PR :) Meanwhile, if you want to be able to merge it, just push a new commit (or rebase), and it should be able to run the other Travis checks while bypassing the keyserver problem. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |