Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰async in generated extension test #28427

Merged
merged 2 commits into from Jun 5, 2020
Merged

馃悰async in generated extension test #28427

merged 2 commits into from Jun 5, 2020

Conversation

alanorozco
Copy link
Member

No description provided.

@alanorozco alanorozco requested a review from caroqliu May 14, 2020 19:34
@alanorozco alanorozco mentioned this pull request May 14, 2020
Merged
samouri
samouri approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how was this working before?

@caroqliu
Copy link
Contributor

how was this working before?

The file that was changed generates new extensions with a gulp task, so the test in this example wasn't being actively executed. It would be once it is duplicated as a new extension code. But we do not do this often anymore, and the bug was only introduced 2 weeks ago by #28286

@alanorozco alanorozco merged commit ad5eb75 into master Jun 5, 2020
@rsimha rsimha deleted the alanorozco-extension-generator-async branch October 19, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alanorozco @caroqliu @samouri @googlebot @ampprojectbot