Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to conformance error #28601

Merged
merged 1 commit into from
May 27, 2020
Merged

fix to conformance error #28601

merged 1 commit into from
May 27, 2020

Conversation

erwinmombay
Copy link
Member

convert NodeList to array before using forEach

@erwinmombay erwinmombay requested a review from rsimha May 27, 2020 20:38
@amp-owners-bot amp-owners-bot bot requested a review from lannka May 27, 2020 20:38
@lannka
Copy link
Contributor

lannka commented May 27, 2020

thanks for the fix :-)

@lannka
Copy link
Contributor

lannka commented May 27, 2020

Broken by #27610

rsimha
rsimha approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a closure conformance error (gulp check-types) and not a linter error (gulp lint). Either way, I believe this should fix it, so LGTM.

@erwinmombay erwinmombay changed the title fix to linter fix to conformance error May 27, 2020
@gmajoulet gmajoulet mentioned this pull request May 27, 2020
Merged
@erwinmombay erwinmombay merged commit d297b66 into ampproject:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erwinmombay @lannka @rsimha @googlebot @ampprojectbot