♿ Add title to amp-a4a iframe #28835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
Jun 15, 2020
|
Restarted travis, and everything passes now with updated visual diff snapshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a title attribute to the AmpA4A generated iframe to improve accessibility. If a title attribute is set on amp-ad this will be used by the iframe. If no title is set, a fallback title of "3rd party ad content" is added.
This fixes the
<frame> or <iframe> elements do not have a titleissue flagged by Lighthouse.This will be applied to any ad
typethat extendsAmpA4A, e.g.doubleclick(for example see http://localhost:8000/examples/ads.amp.html?type=doubleclick).iframetitle will fall back to "3rd party ad content"iframetitle will be "Foo bar baz"