Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update items in viewport before scheduling layout in carousel #2915

Merged
merged 1 commit into from Apr 19, 2016
Merged

Update items in viewport before scheduling layout in carousel #2915

merged 1 commit into from Apr 19, 2016

Conversation

mkhatib
Copy link
Contributor

@mkhatib mkhatib commented Apr 14, 2016

Fixes #2912

@cramforce
Copy link
Member

Nice fix! Could this be covered by a test?

@mkhatib
Copy link
Contributor Author

mkhatib commented Apr 14, 2016

Yes will add some test cases. We don't seem to have test cases currently that covers scheduling.

@mkhatib
Copy link
Contributor Author

mkhatib commented Apr 18, 2016

Added test cases for these! PTAL: @cramforce @sriramkrish85

@cramforce
Copy link
Member

LGTM

@mkhatib mkhatib merged commit 230264f into ampproject:master Apr 19, 2016
@mkhatib mkhatib deleted the carousel-youtube branch April 19, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@camelburrito camelburrito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkhatib @cramforce @camelburrito