Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ambiguous FIE.isVisible() API #29334

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Remove ambiguous FIE.isVisible() API #29334

merged 3 commits into from
Jul 17, 2020

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Jul 17, 2020 •
edited

Partial for #22734.

@dvoytenko dvoytenko requested a review from lannka July 17, 2020 04:58
@google-cla google-cla bot added the cla: yes label Jul 17, 2020
lannka
lannka approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quickly scanned through the code seems like a dead API not being used?

@dvoytenko
Copy link
Contributor Author

quickly scanned through the code seems like a dead API not being used?

@lannka Correct. All users have been removed already. Animations has been the last component still using it.

@dvoytenko dvoytenko merged commit 79041b5 into ampproject:master Jul 17, 2020
@dvoytenko dvoytenko deleted the ampdocfie/remove-embed-vis branch July 17, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @lannka @ampprojectbot