🏗 Added support for ESM and SxG environment in coverage-map
#29800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Aug 12, 2020
rcebulko
reviewed
Aug 13, 2020
kevinkimball
approved these changes
Aug 13, 2020
rcebulko
reviewed
Aug 27, 2020
erwinmombay
approved these changes
Aug 31, 2020
|
@ampproject/build-cop Just one more thing before I merge, because local/dist tests will inconsistently fail. |
|
It's a flakey test. I opened #30124 to deal with it. |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…ject#29800) * incorporate testing for esm and sxg * suggestions * more suggestions, mostly cyan * added map option for explore * correct for esm only * small change * replace * several changes Co-authored-by: Derek Tse <derektse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates a transformer that injects AMP's CSS styles into an HTML, if running under the SxG or ESM environment.
It is assumed that the input HTML will reside in
examples, and then the transformed HTML will reside indist/transformed.