🖍 [bento][social-share] Update outdated social icons and colors #29867
Conversation
krdwan
requested review from
caroqliu,
dvoytenko,
alanorozco and
jridgewell
and removed request for
jridgewell,
caroqliu,
dvoytenko and
alanorozco
|
The smallish big question here: if we're providing our own SVGs here, we should do it in our own source tree - not in |
Makes sense, will update and move the components to within Social Share! |
krdwan
force-pushed
the
social-share-svgs
branch
from
9a26180
to
f15aed7
Compare
|
Changes
|
|
Removed directory of old SVG icons. |
| @@ -1,17 +0,0 @@ | |||
| URL: http://codepen.io/anon/pen/KVZNGp | |||
There was a problem hiding this comment.
This seems premature? Isn't 0.1 still using these resources?
There was a problem hiding this comment.
I agree, thanks for the reminder! I will revert this part!
|
Reversed FB foreground and background colors. Final set of colors in the table shown below
|
| @@ -30,7 +30,6 @@ const COMMON_GLOBS = [ | |||
| 'third_party/inputmask/**/*.js', | |||
| 'third_party/mustache/**/*.js', | |||
| 'third_party/react-dates/bundle.js', | |||
| 'third_party/optimized-svg-icons/social-share-svgs.js', | |||
| 'third_party/set-dom/set-dom.js', | |||
There was a problem hiding this comment.
@dvoytenko Is there someone you would recommend to review this file? I changed it to pass Travis, but am not very familiar with this part of the codebase.
There was a problem hiding this comment.
No. My review should be enough.
|
Final Colors Latest commit reverses facebook foreground and background colors. Final colors noted in table below
Screenshot of default colors Screenshot of styled colors (yellow foreground, blue background) fyi: @nainar |
This reverts commit 86d2fbd.
krdwan
force-pushed
the
social-share-svgs
branch
from
2f1abb0
to
b89327a
Compare
…roject#29867) * Update icons and colors * Update icons * Delete old svg icons directory * Revert "Delete old svg icons directory" This reverts commit 86d2fbd. * Reverse foreground and background colors for FB * Remove third party dependency check in config file * Remove svgs from source.js blob file * Reverse foreground and background colors for Facebook
| @@ -150,7 +149,6 @@ const CLOSURE_SRC_GLOBS = [ | |||
| */ | |||
| const THIRD_PARTY_TRANSFORM_GLOBS = [ | |||
| // JSX syntax should undergo usual transforms | |||
| 'third_party/optimized-svg-icons/social-share-svgs.js', | |||
There was a problem hiding this comment.
@krdwan Curious about why THIRD_PARTY_TRANSFORM_GLOBS was left here an empty list. Any reason to keep it around?
There was a problem hiding this comment.
@rsimha I wasn't sure if this was a generic part of the AMP build system and that it might be updated to be non-empty in the future. From the perspective of this PR and the social-share component, there's no reason to keep it around.
Updated SVGs and background colors:
Visual of the new icons can be found here:
https://docs.google.com/presentation/d/1WmdMNQ0p06ewIby2sIHfZE_2_kwuL4WLrJYjVmZo13Y/edit?usp=sharing
Actual SVG code can be found here:
https://drive.google.com/drive/folders/1l4SbiPL_b8sNPI1OkuoGp4LQApvr_c2-?usp=sharing
Default Background colors are summarized here: