🚀 Remove custom-elements and IntersectionObserver polyfill for SxG. #29971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
Aug 25, 2020
|
@jridgewell Kris mentioned that IntersectionObserver may also not be needed in SxG, should I just remove that in this PR also? |
xiexr151e
changed the title
Just finished. |
|
@xiexr151e What is the size reduction? |
1.96KB, after comparing ESM to SxG binary size. |
jridgewell
approved these changes
Aug 26, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…mpproject#29971) * remove custom elements polyfill * undo viewport * remove install in embed * remove IntersectionObserver * lint * remove 2 polyfills for esm/sxg Co-authored-by: Derek Tse <derektse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jridgewell mentioned that the custom-elements polyfill could be removed for the SxG build. This PR is a one line change that achieves that.
In addition, the IntersectionObserver polyfill can also be removed as mentioned by @erwinmombay.