📖 Added note about data-colorscheme to amp-facebook-comments docs #29979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nainar
reviewed
Aug 25, 2020
kristoferbaxter
approved these changes
Sep 4, 2020
|
Looks like there is a merge conflict, worth resolving so we can get this change in. |
|
Can we land this? |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…pproject#29979) * Added note about data-colorscheme * Added line breaks * Update amp-facebook-comments.md * Added links * Added to separate deprecated attributes section * Ran prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #29812.
Facebook's SDK is either buggy or the docs are outdated in regards to data-colorscheme, so a note has been added notifying users regarding this.