Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup AdSense/Doubleclick round adx/ady #30081

Merged
merged 1 commit into from Sep 1, 2020
Merged

Cleanup AdSense/Doubleclick round adx/ady #30081

merged 1 commit into from Sep 1, 2020

Conversation

keithwrightbos
Copy link
Contributor

Launched in #29737

@google-cla google-cla bot added the cla: yes label Sep 1, 2020
@amp-owners-bot
Copy link

amp-owners-bot bot commented Sep 1, 2020

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

jeffkaufman
jeffkaufman approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@jeffkaufman jeffkaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward cleanup of a launched experiment

@keithwrightbos keithwrightbos merged commit 26c30f0 into ampproject:master Sep 1, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@keithwrightbos @ed-bird
Cleanup AdSense/Doubleclick round adx/ady (ampproject#30081)
8bcd22d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkaufman jeffkaufman jeffkaufman approved these changes

@lannka lannka lannka approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@keithwrightbos @jeffkaufman @lannka @ampprojectbot