Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [bento][amp-date-countdown] Initial Preact component for amp-date-countdown #30092

Merged
merged 12 commits into from
Sep 14, 2020
Merged

✨ [bento][amp-date-countdown] Initial Preact component for amp-date-countdown #30092

merged 12 commits into from
Sep 14, 2020

Commits on Sep 14, 2020

  1. First commit Preact component

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    d762f45 View commit details
    Browse the repository at this point in the history

  2. Add clear comments for helper functions

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    c95583d View commit details
    Browse the repository at this point in the history

  3. Various review comment updates

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    56c4e9e View commit details
    Browse the repository at this point in the history

  4. More review updates

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    6ea8b86 View commit details
    Browse the repository at this point in the history

  5. More review updates

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    93f9de2 View commit details
    Browse the repository at this point in the history

  6. Add useMemo

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    1b6b5bc View commit details
    Browse the repository at this point in the history

  7. Updates for code review

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    fd64bc6 View commit details
    Browse the repository at this point in the history

  8. Review comments and rebase

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    a5161d0 View commit details
    Browse the repository at this point in the history

  9. Remove rebase conflict

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    f1cfff0 View commit details
    Browse the repository at this point in the history

  10. remove quotes on playable

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    2cfca11 View commit details
    Browse the repository at this point in the history

  11. Remove date format from epoch

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    991f2ec View commit details
    Browse the repository at this point in the history

  12. add quotes for object keys that are output to template

    @krdwan
    krdwan committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    955c8db View commit details
    Browse the repository at this point in the history