馃悰 Report zero visibility for zero size element #30105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micajuine-ho
approved these changes
Sep 3, 2020
Comment on lines
+656
to
+665
| // zero element size, high resolution screen. | ||
| inOb.callback([ | ||
| { | ||
| target, | ||
| intersectionRatio: 0.8, | ||
| intersectionRect: layoutRectLtwh(0, 0, 1, 1), | ||
| boundingClientRect: layoutRectLtwh(1, 1, 10, 0.452), | ||
| }, | ||
| ]); | ||
| expect(model.getVisibility_()).to.equal(0); |
| @@ -872,7 +872,6 @@ export class VisibilityManagerForDoc extends VisibilityManager { | |||
| Number(intersection.width), | |||
| Number(intersection.height) | |||
| ); | |||
| // TODO(#29618): Remove after ampim investigation | |||
There was a problem hiding this comment.
Is there any more cleanup needed?
There was a problem hiding this comment.
Yes. We need to move all the related error logs.
I removed this TODO because boundingClientRect needs to stay because we need element's width/height value.
| @@ -908,6 +906,12 @@ export class VisibilityManagerForDoc extends VisibilityManager { | |||
| intersectionRatio = Math.min(Math.max(intersectionRatio, 0), 1); | |||
| const id = getElementId(target); | |||
| const trackedElement = this.trackedElements_[id]; | |||
| if (boundingClientRect.width < 1 || boundingClientRect.height < 1) { | |||
There was a problem hiding this comment.
should this be collapsed with the declaration above?
if (width<1 || height<1) {
// Set intersectionRatio to 0 when the element is not visible.
// Use < 1 because the width/height can be a double values.
intersectionRatio = 0;
} else {
intersectionRatio = Math.min(Math.max(intersectionRatio, 0), 1);
}
This was referenced Sep 17, 2020
zhouyx
added a commit
that referenced
this pull request
Sep 17, 2020
ampprojectbot
pushed a commit
that referenced
this pull request
Sep 18, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* check belement size before setting visible percentage * fix test * nit
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
)" (ampproject#30284) This reverts commit 584158c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29946