馃悰 Fixing window reference for amp-ad type kargo #30174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
requested changes
Sep 10, 2020
ads/kargo.js
Outdated
| @@ -45,9 +45,9 @@ export function kargo(global, data) { | |||
| 'kargo-load', | |||
| function (done) { | |||
| // load AdTag in Master window | |||
| loadScript(this, kargoScriptUrl, () => { | |||
| loadScript(window, kargoScriptUrl, () => { | |||
There was a problem hiding this comment.
Can you use global instead of window?
powerivq
approved these changes
Sep 10, 2020
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Sep 15, 2020
The underlying bug is that in strict mode, the implicit `this` of a function is `undefined`. In sloppy, it was the global `window`. This extends the work done in ampproject#30174 and ampproject#30235.
powerivq
pushed a commit
to powerivq/amphtml
that referenced
this pull request
Sep 15, 2020
* correcting window reference for amp-ad kargo * changing window reference to global
This was referenced Sep 15, 2020
ampprojectbot
pushed a commit
that referenced
this pull request
Sep 16, 2020
* correcting window reference for amp-ad kargo * changing window reference to global (cherry picked from commit 95e9db0)
ampprojectbot
pushed a commit
that referenced
this pull request
Sep 16, 2020
* correcting window reference for amp-ad kargo * changing window reference to global (cherry picked from commit 95e9db0)
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Sep 25, 2020
The underlying bug is that in strict mode, the implicit `this` of a function is `undefined`. In sloppy, it was the global `window`. This extends the work done in ampproject#30174 and ampproject#30235.
jridgewell
added a commit
that referenced
this pull request
Sep 25, 2020
* Ban use of the implicit global this in functions The underlying bug is that in strict mode, the implicit `this` of a function is `undefined`. In sloppy, it was the global `window`. This extends the work done in #30174 and #30235. * Fix tests Seems unrelated, maybe the error is just firing because the related files were changed so now the test is running. * Remove fixer * Fix lint
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* correcting window reference for amp-ad kargo * changing window reference to global
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Ban use of the implicit global this in functions The underlying bug is that in strict mode, the implicit `this` of a function is `undefined`. In sloppy, it was the global `window`. This extends the work done in ampproject#30174 and ampproject#30235. * Fix tests Seems unrelated, maybe the error is just firing because the related files were changed so now the test is running. * Remove fixer * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thisreference in loadScript call with localwindow