Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-ad type broadstreetads: Support renderStart() #30185

Merged
merged 1 commit into from
Sep 21, 2020
Merged

amp-ad type broadstreetads: Support renderStart() #30185

merged 1 commit into from
Sep 21, 2020

Conversation

katzgrau
Copy link
Contributor

This PR implements the render-start requested by the AMP team on #12475

@google-cla google-cla bot added the cla: yes label Sep 10, 2020
@katzgrau katzgrau changed the title 🚀 ad-type broadstreetads: Support renderStart() amp-ad type broadstreetads: Support renderStart() Sep 10, 2020
calebcordry
calebcordry approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, thanks for maintaining this extension!

@calebcordry calebcordry merged commit 7b45d68 into ampproject:master Sep 21, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@katzgrau @ed-bird
Support renderStart() in AMP (ampproject#30185)
80968fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katzgrau @calebcordry @ampprojectbot