Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Move tests and reference implementation to use promise on context.requestResize API #30192

Merged
merged 1 commit into from Sep 11, 2020
Merged

♻️ Move tests and reference implementation to use promise on context.requestResize API #30192

merged 1 commit into from Sep 11, 2020

Conversation

powerivq
Copy link
Contributor

We have moved from onRequestSuccess to promise. These are the references needing to be changed.

@google-cla google-cla bot added the cla: yes label Sep 10, 2020
calebcordry
calebcordry reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I didn't realize we had these examples :)

@powerivq powerivq merged commit 1d32b79 into ampproject:master Sep 11, 2020
@powerivq powerivq deleted the fix-onresizes branch September 11, 2020 22:04
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@powerivq @ed-bird
Move tests and reference implementation to use promise on context.req…
776f673 
…uestResize (ampproject#30192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@powerivq @calebcordry @ampprojectbot