Move no-signing to RTV exp #30201
Merged
Move no-signing to RTV exp #30201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danielrozenberg! These files were changed: Hey @estherkim! These files were changed: Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: |
calebcordry
changed the title
estherkim
approved these changes
Sep 11, 2020
powerivq
requested changes
Sep 11, 2020
extensions/amp-a4a/0.1/amp-a4a.js
Outdated
| NO_SIGNING_EXP.experiment | ||
| ); | ||
| // eslint-disable-next-line no-undef | ||
| return NO_SIGNING_RTV; |
There was a problem hiding this comment.
Do we need to cast it to boolean? (if undefined)
| */ | ||
| export const NO_SIGNING_EXP = { | ||
| id: 'a4a-no-signing', | ||
| control: '21066324', |
There was a problem hiding this comment.
If we remove this, where do we track the exp id?
There was a problem hiding this comment.
This is an RTV experiment so we just compare version numbers.
powerivq
approved these changes
Sep 11, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* move to rtv * add exp config * missed e2e test * coerce to bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move branch level No Signing experiment to ExperimentA slot to stop polluting canary logs.
link without whitespace in diff :) https://github.com/ampproject/amphtml/pull/30201/files?w=1