馃悰 Fix story ads in no signing exp #30224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Sep 14, 2020
| * @return {!IArrayLike} | ||
| */ | ||
| export function getAmpCtaMetaTags(doc) { | ||
| return doc.querySelectorAll('meta[name^=amp-cta-]'); |
There was a problem hiding this comment.
did you try one query to select both?
meta[name^=amp-cta-],meta[name^=amp4ads-vars-]
There was a problem hiding this comment.
Switched to single selector.
|
We started with |
lannka
approved these changes
Sep 14, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* look for more tags * use single selector * cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the normal case the cta url & cta type are extracted from the metadata obj and added as data-var attrs to the element. In the no-signing case the metadata obj does not exist. This PR extends what we query for in the ad doc to find the
<meta name=amp-cta-*>elements.Should fix broken experimentA on master builds.