馃悰 Fix ad index value in IMA video #30249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
changed the title
alanorozco
force-pushed
the
no-label
branch
from
1c4b47c
to
f3a3373
Compare
calebcordry
approved these changes
Sep 16, 2020
zhouyx
reviewed
Sep 16, 2020
zhouyx
approved these changes
Sep 16, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
Fixes ampproject#30155. Data from IMA SDK gives incorrect values required for interpolated label with currently used APIs, but we can use equivalents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #30155.
Data from IMA SDK gives incorrect values required for interpolated label with currently used APIs, but a different one is equivalent.
Before: