馃彈 Add a default assignment aliasing transform #30250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay! These files were changed: |
dvoytenko
suggested changes
Sep 21, 2020
...efault-assignment/test/fixtures/transform-assertions/should-transform-destructures/output.js
Outdated
Show resolved
Hide resolved
...efault-assignment/test/fixtures/transform-assertions/should-transform-destructures/output.js
Outdated
Show resolved
Hide resolved
| @@ -243,7 +243,8 @@ class AmpCarousel extends AMP.BaseElement { | |||
| * actionSource: (!ActionSource|undefined), | |||
| * }=} options | |||
| */ | |||
| goToSlide(index, {smoothScroll = false, actionSource} = {}) { | |||
| goToSlide(index, options = {}) { | |||
| const {smoothScroll = false, actionSource} = options; | |||
There was a problem hiding this comment.
Could you clarify why this again?
There was a problem hiding this comment.
The @param is named, and it's too difficult to figure out what that is when creating the binding. If it's not named properly, we closure will complain throw.
...efault-assignment/test/fixtures/transform-assertions/should-transform-destructures/output.js
Outdated
Show resolved
Hide resolved
dvoytenko
approved these changes
Sep 21, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Add a default assignment aliasing transform Fixes ampproject#29293 * Only transform parameter default assignments * Lint * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29293