when in ESM mode, copy the the parent runtime CSS into the friendly iframe #30257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Sep 16, 2020
erwinmombay
force-pushed
the
fix-a4a-ad-2
branch
from
a650103
to
2f38b9e
Compare
|
Hey @rsimha! These files were changed: |
erwinmombay
force-pushed
the
fix-a4a-ad-2
branch
2 times, most recently
from
07ac92c
to
8ac5924
Compare
erwinmombay
changed the title
erwinmombay
force-pushed
the
fix-a4a-ad-2
branch
from
8ac5924
to
d87ec94
Compare
jridgewell
approved these changes
Sep 17, 2020
kristoferbaxter
approved these changes
Sep 21, 2020
…oubleclick-impl copy the styles from the parent window to the child friendly ad iframe
erwinmombay
force-pushed
the
fix-a4a-ad-2
branch
from
d87ec94
to
cd6141d
Compare
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…oubleclick-impl (ampproject#30257) copy the styles from the parent window to the child friendly ad iframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a major bug while we were experimenting with ads.
this would silently (because it is pre closure) remove the call for installStylesForDoc in src/friendly-iframe-embed.js which would then break ads because no styles are installed in the friendly iframe.
this was only triggered in the esm build because the "filter-imports" plugin was only turned on in the esm build.