🐛 Fix Animation.animate breakage caused by missing import.
#30264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexr151e
requested review from
kristoferbaxter,
erwinmombay and
kevinkimball
xiexr151e
changed the title
Animation.animate breakage caused by missing import.
|
Looks like it's fixing #30253 |
kristoferbaxter
approved these changes
Sep 16, 2020
|
@ampproject/build-cop This PR is currently blocked by the handshake test. |
|
#30247 has been merged to fix that test |
dreamofabear
approved these changes
Sep 17, 2020
rcebulko
reviewed
Sep 17, 2020
rcebulko
approved these changes
Sep 17, 2020
ampprojectbot
pushed a commit
that referenced
this pull request
Sep 18, 2020
* fix * added lint and test for bug * weird space * rename test * dupe test * comment Co-authored-by: Derek Tse <derektse@google.com> (cherry picked from commit d83351b)
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…ect#30264) * fix * added lint and test for bug * weird space * rename test * dupe test * comment Co-authored-by: Derek Tse <derektse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
fixed-layer.js,Animationis supposed to be imported but it was missing.Fixes #30253