🏗 Lint for $ in animation-name

[alanorozco]

Will error:

  const JSS = {
    foo: {
+ // The animation name in property animationName should start with $ (e.g. $foo).
+ // This scopes it to a keyframes rule present in this module.
      animationName: 'bar',
+ // ----------------^
    },
  };

  const JSS = {
    foo: {
+ // The animation name in property animation should start with $.
+ // This scopes it to a keyframes rule present in this module.
      animation: 'bar linear 0.5s',
+ // ------------^
    },
  };

[amp-owners-bot]

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/eslint-rules/jss-animation-name.js

[samouri]

Two thoughts:

1. Do we ever ever reference animation names from a different file, e.g. from ampshared?
2. My personal preference for a rule like this is not to autofix and instead just have a good message. I personally have a workflow where I exclusively run lint with the --fix option, and this could just as easily hide an issue as fix it.

[samouri]

Had two small comments, overall lgtm

[alanorozco]

1. No, they're always set in their same CSS file, so it wouldn't break scoping.
2. Fair enough, removed fix function.