Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 Safari 14 Fixed the Web Animations API implementation #30299

Merged
merged 1 commit into from
Sep 21, 2020
Merged

馃殌 Safari 14 Fixed the Web Animations API implementation #30299

merged 1 commit into from
Sep 21, 2020

Conversation

kristoferbaxter
Copy link
Contributor

@kristoferbaxter kristoferbaxter commented Sep 18, 2020 •
edited

We need only polyfill when the major version of Safari is less than 14.

Example of Safari not polyfilled and working as expected.
safari-no-polyfill

Example inside Web Story.
safari-no-polyfill-story

@google-cla google-cla bot added the cla: yes label Sep 18, 2020
alanorozco
alanorozco approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀馃帀馃帀

@kristoferbaxter kristoferbaxter merged commit 7edbc9a into ampproject:master Sep 21, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@kristoferbaxter @ed-bird
iOS 14 Fixed the Web Animations API implementation (ampproject#30299)
4f3f6cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristoferbaxter @alanorozco @ampprojectbot