Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 amp-auto-ads: Fix a typo in firstimpression.io network config #30313

Merged
merged 1 commit into from
Sep 21, 2020
Merged

馃悰 amp-auto-ads: Fix a typo in firstimpression.io network config #30313

merged 1 commit into from
Sep 21, 2020

Conversation

Zer0Divis0r
Copy link
Contributor

Fixed a minor typo in network config code

@google-cla google-cla bot added the cla: yes label Sep 21, 2020
calebcordry
calebcordry approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this extension!

@calebcordry calebcordry merged commit 0528ba8 into ampproject:master Sep 21, 2020
@Zer0Divis0r Zer0Divis0r deleted the firstimpression-io branch November 8, 2020 16:03
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@Zer0Divis0r @ed-bird
Fix a typo in firstimpression.io network config (ampproject#30313)
e9bd25f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zer0Divis0r @calebcordry @ampprojectbot