✨Add a close button to amp-ad stick type #30323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
sticky-ad-close-btn
branch
3 times, most recently
from
6ae3894
to
fbc730d
Compare
calebcordry
reviewed
Sep 22, 2020
powerivq
force-pushed
the
sticky-ad-close-btn
branch
from
fbc730d
to
6648ee2
Compare
powerivq
force-pushed
the
sticky-ad-close-btn
branch
from
6648ee2
to
d967b2a
Compare
calebcordry
approved these changes
Sep 24, 2020
| import {moveLayoutRect} from '../../../src/layout-rect'; | ||
|
|
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Add a close button to amp-ad stick type * Update amp-ad-3p-impl.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button will render when the ad is rendered the first time.
It also adds tests to cover #30306