Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Share: update wrapper and propagate size from the AMP element #30326

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Social Share: update wrapper and propagate size from the AMP element #30326

merged 1 commit into from
Sep 22, 2020

Conversation

dvoytenko
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 22, 2020
krdwan
krdwan approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@krdwan krdwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvoytenko dvoytenko merged commit 6170365 into ampproject:master Sep 22, 2020
@dvoytenko dvoytenko deleted the bento/social-share-wrapper branch September 22, 2020 17:53
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@ed-bird
Social Share: update wrapper and propagate size from the AMP element (a…
1fa359a 
…mpproject#30326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krdwan krdwan krdwan approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @krdwan @ampprojectbot