Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix failing isAnimationNone assertion in IE11 #30387

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Sep 24, 2020

The animation-play-state property in IE11 is apparently known to be a bit funky, and returns an empty string for document.body.style.animationPlayState when the property remains unset through the CSS shorthand syntax. Since empty string isn't part of the allowed set defined for the assertion, the isAnimationNone fails for tests in IE11.

This PR adds the empty string to the accepted values for animation-play-state

Part of broad effort under #28152 to enable IE11 integration tests as blocking

Fixes failure:
image

@rcebulko
Copy link
Contributor Author

rcebulko commented Sep 24, 2020

@caroqliu requested you because I know this is UI territory, last person to touch most of this was Carlos many years ago, so I figured either you'd know what's up or you'd know who would.

@caroqliu
Copy link
Contributor

Thanks for the heads up Ryan. Paging @alanorozco who's most likely to know better what relies on isAnimationNone and why.

@rcebulko rcebulko merged commit fe7358a into ampproject:master Sep 24, 2020
@rcebulko rcebulko deleted the ie11-anim-play-state branch September 24, 2020 21:50
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants