馃彈 Run default task in parallel with storybook-amp #30392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @wassgha! These files were changed: |
alanorozco
commented
Sep 24, 2020
dvoytenko
approved these changes
Sep 24, 2020
|
LGTM for me, but please also get LGTM from @ampproject/wg-infra |
rcebulko
reviewed
Sep 24, 2020
rsimha
approved these changes
Sep 25, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
Previously, you'd have to run gulp at the same time as storybook-amp to serve binaries from localhost:8000.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you'd have to run
gulpat the same time asstorybook-ampto serve binaries fromlocalhost:8000.