-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Lotame: Change to allow limiting the maximum number of audiences. #30655
✨ Lotame: Change to allow limiting the maximum number of audiences. #30655
Conversation
…ated Lotame vendor link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for maintaining this extension!
looks like you have a lint error, you can expose it with |
I'm honestly not sure what you mean. When I try |
Here is the link to our failing CI: https://travis-ci.org/github/ampproject/amphtml/jobs/735766000 hopefully you can see it. Not sure whats going on with |
…ated Lotame vendor link.
…ated Lotame vendor link.
…ated Lotame vendor link.
…phtml into lotame_limit_audiences
Yeah, that was it. I didn't run lint/prettify before submitting, because it wasn't a thing when I first wrote the extension. I think that should do it. |
Thanks! I think now it failing due to the broken link check in |
URLs fixed. Thanks for your patience. |
…mpproject#30655) * Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link. * Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link. * Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link. * Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link. * Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.
Also updated the Lotame vendor link.