Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Lotame: Change to allow limiting the maximum number of audiences. #30655

Merged
merged 10 commits into from
Oct 15, 2020

Conversation

Tonsil
Copy link
Contributor

@Tonsil Tonsil commented Oct 14, 2020

Also updated the Lotame vendor link.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this extension!

@calebcordry
Copy link
Member

looks like you have a lint error, you can expose it with gulp lint or try gulp lint --fix but make sure you are in a recoverable state before you try the fix.

@Tonsil
Copy link
Contributor Author

Tonsil commented Oct 14, 2020

looks like you have a lint error, you can expose it with gulp lint or try gulp lint --fix but make sure you are in a recoverable state before you try the fix.

I'm honestly not sure what you mean. When I try gulp lint it complains about a helper.js file (MODULE_NOT_FOUND) that has nothing to do with my changes.

@calebcordry
Copy link
Member

Here is the link to our failing CI: https://travis-ci.org/github/ampproject/amphtml/jobs/735766000 hopefully you can see it. Not sure whats going on with helper.js, you can maybe try rebasing or merging the latest master. Also maybe run yarn to make sure everything is up to date? Let me know if you still have issues.

@Tonsil
Copy link
Contributor Author

Tonsil commented Oct 14, 2020

Here is the link to our failing CI: https://travis-ci.org/github/ampproject/amphtml/jobs/735766000 hopefully you can see it. Not sure whats going on with helper.js, you can maybe try rebasing or merging the latest master. Also maybe run yarn to make sure everything is up to date? Let me know if you still have issues.

Yeah, that was it. I didn't run lint/prettify before submitting, because it wasn't a thing when I first wrote the extension. I think that should do it.

@calebcordry
Copy link
Member

Thanks! I think now it failing due to the broken link check in extensions/amp-analytics/analytics-vendors-list.md (not your fault) I am working to see what we can do with these links cc/ @ampproject/wg-analytics

@calebcordry
Copy link
Member

URLs fixed. Thanks for your patience.

@calebcordry calebcordry merged commit 52de546 into ampproject:master Oct 15, 2020
@Tonsil Tonsil deleted the lotame_limit_audiences branch October 15, 2020 18:23
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
…mpproject#30655)

* Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.

* Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.

* Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.

* Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.

* Lotame: Change to allow limiting the maximum number of audiences. Updated Lotame vendor link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants