Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [bento][amp-accordion] Move aria-expanded from section to header #30721

Merged
merged 1 commit into from
Oct 22, 2020
Merged

✨ [bento][amp-accordion] Move aria-expanded from section to header #30721

merged 1 commit into from
Oct 22, 2020

Conversation

krdwan
Copy link
Contributor

@krdwan krdwan commented Oct 19, 2020

Accordion Tracker Issue: #30445

Move the aria-expanded attribute from the section to its first child element header to match 0.1.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

This was referenced Oct 19, 2020
Merged
Closed
@dvoytenko
Copy link
Contributor

LGTM from me, but please get LGTM from @caroqliu

@krdwan krdwan merged commit 8ea4678 into ampproject:master Oct 22, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@krdwan @ed-bird
Move aria-expanded from section to header (ampproject#30721)
0174cd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@caroqliu caroqliu caroqliu approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@krdwan @CLAassistant @dvoytenko @caroqliu @ampprojectbot