馃И Add story ad rendering to inabox. #30782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danielrozenberg! These files were changed: |
calebcordry
commented
Oct 21, 2020
| getStoryAdMetadataFromDoc, | ||
| maybeCreateAttribution, | ||
| validateCtaMetadata, | ||
| } from '../../extensions/amp-story-auto-ads/0.1/story-ad-ui'; |
There was a problem hiding this comment.
I know we discussed importing from extension being a little weird, but I wasn't sure where to put them. Happy to move to a new file path.
There was a problem hiding this comment.
i'm fine with this as long as the compiler does not complain
There was a problem hiding this comment.
@lannka @calebcordry Looks like this did break compilation. https://travis-ci.com/github/ampproject/amphtml/jobs/405408314#L418
Can we fix before this goes to beta tomorrow?
/cc @ampproject/build-cop
calebcordry
changed the title
danielrozenberg
approved these changes
Oct 21, 2020
lannka
approved these changes
Oct 22, 2020
| getStoryAdMetadataFromDoc, | ||
| maybeCreateAttribution, | ||
| validateCtaMetadata, | ||
| } from '../../extensions/amp-story-auto-ads/0.1/story-ad-ui'; |
There was a problem hiding this comment.
i'm fine with this as long as the compiler does not complain
|
|
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* render inabox * css * experiment * comments * exp fix * types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new logic to inabox that detects for story ad metadata, and if it exists, renders as a story ad.
Part of #27851