Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-list: Remove unnecessary keyboard focus stops #30844

Merged
merged 3 commits into from
Oct 23, 2020
Merged

amp-list: Remove unnecessary keyboard focus stops #30844

merged 3 commits into from
Oct 23, 2020

Conversation

caroqliu
Copy link
Contributor

Fixes #29559

samouri
samouri approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kind of PR. Exclusively deletions 💯

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@caroqliu caroqliu merged commit ce3b4cd into ampproject:master Oct 23, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@caroqliu @ed-bird
amp-list: Remove unnecessary keyboard focus stops (ampproject#30844)
b92d7db 
* Do not add tabindex by default

* Remove extraneous helpers

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@samouri samouri samouri approved these changes

@zhouyx zhouyx zhouyx approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-list: Redundant/unnecessary keyboard focus stops
6 participants
@caroqliu @CLAassistant @alanorozco @samouri @zhouyx @ampprojectbot