Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Move real time config manager to service directory #30966

Merged
merged 1 commit into from Nov 6, 2020

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Nov 3, 2020

Motive #20259

We want to share the remote config module between multiple extensions. This PR is the first step to move remote-config into a service. It is not a service yet. This PR simply moves the files. Conversion to a service will come as a separate PR.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2020

CLA assistant check
All committers have signed the CLA.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 3, 2020

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/test/test-doubleclick-rtc.js

@powerivq powerivq removed the request for review from kristoferbaxter November 3, 2020 03:15
@powerivq powerivq force-pushed the rtc-move branch 5 times, most recently from b4c7bdb to 60222f3 Compare November 3, 2020 06:52
@powerivq powerivq merged commit 51c257b into ampproject:master Nov 6, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants