Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉 Add images for player docs #30984

Merged
merged 2 commits into from Nov 3, 2020
Merged

馃摉 Add images for player docs #30984

merged 2 commits into from Nov 3, 2020

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Nov 3, 2020

No description provided.

@Enriqe Enriqe requested a review from gmajoulet November 3, 2020 19:55
gmajoulet
gmajoulet reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can save ~50-80% in filesize for most of these images by running them through some optimizer, without reducing their quality in any visible way. Can you look into that?

@Enriqe Enriqe merged commit befbea0 into ampproject:master Nov 3, 2020
@Enriqe Enriqe deleted the player-nov-docs-imgs branch November 19, 2020 19:21
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@Enriqe @ed-bird
馃摉 Add images for player docs (ampproject#30984)
f998f13 
* add images for docs

* tinify pics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enriqe @gmajoulet @ampprojectbot